From 9a4ad7153716360beea3d05e60a38689a34839b9 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Tue, 14 Apr 2026 22:52:07 +0100 Subject: [PATCH 1/4] created new branch and add diffrent test cases --- .../2-practice-tdd/get-ordinal-number.test.js | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index adfa58560..5ed773a58 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -18,3 +18,25 @@ test("should append 'st' for numbers ending with 1, except those ending with 11" expect(getOrdinalNumber(21)).toEqual("21st"); expect(getOrdinalNumber(131)).toEqual("131st"); }); + +// Case 2: numbers ending with 2 (except 12) +test("should append 'nd' for numbers ending with 2, except those ending with 12", () => { + expect(getOrdinalNumber(2)).toEqual("2nd"); + expect(getOrdinalNumber(22)).toEqual("22nd"); + expect(getOrdinalNumber(142)).toEqual("142nd"); +}); + +// Case 3: numbers ending with 3 (except 13) +test("should append 'rd' for numbers ending with 3, except those ending with 13", () => { + expect(getOrdinalNumber(3)).toEqual("3rd"); + expect(getOrdinalNumber(23)).toEqual("23rd"); + expect(getOrdinalNumber(143)).toEqual("143rd"); +}); + +// Case 4: numbers ending with 0, 4-9 (except 10-19) +test("should append 'th' for numbers ending with 0, 4-9, except those ending with 10-19", () => { + expect(getOrdinalNumber(0)).toEqual("0th"); + expect(getOrdinalNumber(4)).toEqual("4th"); + expect(getOrdinalNumber(10)).toEqual("10th"); + expect(getOrdinalNumber(14)).toEqual("14th"); +}); \ No newline at end of file From e09e6484caccda09b9aa8d2f56556f26d6c91c1d Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Tue, 14 Apr 2026 22:53:57 +0100 Subject: [PATCH 2/4] implemented a function and wrote different test cases for the repeat string function --- Sprint-3/2-practice-tdd/repeat-str.js | 6 ++++-- Sprint-3/2-practice-tdd/repeat-str.test.js | 20 ++++++++++++++++++-- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/Sprint-3/2-practice-tdd/repeat-str.js b/Sprint-3/2-practice-tdd/repeat-str.js index 3838c7b00..96bda5eb4 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.js +++ b/Sprint-3/2-practice-tdd/repeat-str.js @@ -1,5 +1,7 @@ -function repeatStr() { - return "hellohellohello"; +function repeatStr(str, count) { + if( count >= 0 ) + {return str.repeat (count)}; +else { return 'invalid count'}; } module.exports = repeatStr; diff --git a/Sprint-3/2-practice-tdd/repeat-str.test.js b/Sprint-3/2-practice-tdd/repeat-str.test.js index a3fc1196c..16e274a4b 100644 --- a/Sprint-3/2-practice-tdd/repeat-str.test.js +++ b/Sprint-3/2-practice-tdd/repeat-str.test.js @@ -20,13 +20,29 @@ test("should repeat the string count times", () => { // Given a target string `str` and a `count` equal to 1, // When the repeatStr function is called with these inputs, // Then it should return the original `str` without repetition. - +test("should repeat the string count times", () => { + const str = "hello"; + const count = 1; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual("hello"); +}); // Case: Handle count of 0: // Given a target string `str` and a `count` equal to 0, // When the repeatStr function is called with these inputs, // Then it should return an empty string. - +test("should repeat the string count times", () => { + const str = "hello"; + const count = 0; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual(" "); +}); // Case: Handle negative count: // Given a target string `str` and a negative integer `count`, // When the repeatStr function is called with these inputs, // Then it should throw an error, as negative counts are not valid. +test("should repeat the string count times", () => { + const str = "hello"; + const count = -1; + const repeatedStr = repeatStr(str, count); + expect(repeatedStr).toEqual("invalid count"); +}); From e947f0f5d47e093677ee35b5eefb2fa7bbfebea0 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Tue, 14 Apr 2026 23:09:38 +0100 Subject: [PATCH 3/4] implement count function and wrote diffrent test cases. --- Sprint-3/2-practice-tdd/count.js | 13 ++++++++-- Sprint-3/2-practice-tdd/count.test.js | 36 +++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/Sprint-3/2-practice-tdd/count.js b/Sprint-3/2-practice-tdd/count.js index 95b6ebb7d..3fc706aa8 100644 --- a/Sprint-3/2-practice-tdd/count.js +++ b/Sprint-3/2-practice-tdd/count.js @@ -1,5 +1,14 @@ function countChar(stringOfCharacters, findCharacter) { - return 5 -} + if (typeof stringOfCharacters !== "string") return 0; + + let count = 0; + for (let char of stringOfCharacters) { + if (char === findCharacter) { + count++; + } + } + + return count; +} module.exports = countChar; diff --git a/Sprint-3/2-practice-tdd/count.test.js b/Sprint-3/2-practice-tdd/count.test.js index 179ea0ddf..e4beda50f 100644 --- a/Sprint-3/2-practice-tdd/count.test.js +++ b/Sprint-3/2-practice-tdd/count.test.js @@ -22,3 +22,39 @@ test("should count multiple occurrences of a character", () => { // And a character `char` that does not exist within `str`. // When the function is called with these inputs, // Then it should return 0, indicating that no occurrences of `char` were found. +test("should return 0 when character does not exist in string", () => { + const str = "hello"; + const char = "z"; + const count = countChar(str, char); + expect(count).toEqual(0); +}); + +// Scenario: Case Sensitivity +test("should be case sensitive", () => { + expect(countChar("AaAa", "a")).toBe(2); +}); + +// Scenario: Empty String +test("should return 0 for an empty string", () => { + expect(countChar("", "a")).toBe(0); +}); + +// Scenario: Special Characters +test("should count special characters", () => { + expect(countChar("!@#$%^&*()!", "!")).toBe(2); +}); + +// Scenario: Non-String Inputs +test("should handle non-string inputs gracefully", () => { + expect(countChar(12345, "1")).toBe(0); + expect(countChar(null, "a")).toBe(0); + expect(countChar(undefined, "a")).toBe(0); +}); +test ("should count numeric characters in a string", () => { + + expect(countChar("12345", "1")).toBe(1); +}); +// Scenario: Space Character +test("should count spaces correctly", () => { + expect(countChar("a a a", " ")).toBe(2); +}); \ No newline at end of file From 8a279fcd0800d94141fdac3b90ce2296ef42f0b9 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sat, 18 Apr 2026 11:30:58 +0100 Subject: [PATCH 4/4] I added tests for 11,12 13 and reimplemented the function --- Sprint-3/2-practice-tdd/get-ordinal-number.js | 10 ++++++++-- Sprint-3/2-practice-tdd/get-ordinal-number.test.js | 6 ++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.js b/Sprint-3/2-practice-tdd/get-ordinal-number.js index f95d71db1..8613add93 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.js @@ -1,5 +1,11 @@ -function getOrdinalNumber(num) { - return "1st"; +function getOrdinalNumber(n) { + if (n % 100 >= 11 && n % 100 <= 13) return n + "th"; + + if (n % 10 === 1) return n + "st"; + if (n % 10 === 2) return n + "nd"; + if (n % 10 === 3) return n + "rd"; + + return n + "th"; } module.exports = getOrdinalNumber; diff --git a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js index 5ed773a58..c6924c443 100644 --- a/Sprint-3/2-practice-tdd/get-ordinal-number.test.js +++ b/Sprint-3/2-practice-tdd/get-ordinal-number.test.js @@ -38,5 +38,7 @@ test("should append 'th' for numbers ending with 0, 4-9, except those ending wit expect(getOrdinalNumber(0)).toEqual("0th"); expect(getOrdinalNumber(4)).toEqual("4th"); expect(getOrdinalNumber(10)).toEqual("10th"); - expect(getOrdinalNumber(14)).toEqual("14th"); -}); \ No newline at end of file + expect(getOrdinalNumber(11)).toEqual("11th"); + expect(getOrdinalNumber(12)).toEqual("12th"); + expect(getOrdinalNumber(13)).toEqual("13th"); +});