From 4a54df3357659047eaf34ae8acb0a43166ba5954 Mon Sep 17 00:00:00 2001 From: guptapratykshh Date: Sun, 19 Apr 2026 09:43:41 +0530 Subject: [PATCH 1/2] fix: remove digit separators from integer literals for clang-scan-deps C++ module compat Signed-off-by: guptapratykshh --- include/exec/detail/bwos_lifo_queue.hpp | 4 ++-- include/exec/linux/io_uring_context.hpp | 6 +++--- include/exec/windows/filetime_clock.hpp | 2 +- include/stdexec/__detail/__config.hpp | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/exec/detail/bwos_lifo_queue.hpp b/include/exec/detail/bwos_lifo_queue.hpp index 789662e70..417708b9c 100644 --- a/include/exec/detail/bwos_lifo_queue.hpp +++ b/include/exec/detail/bwos_lifo_queue.hpp @@ -397,10 +397,10 @@ namespace experimental::execution::bwos template lifo_queue::block_type::block_type(std::size_t block_size, Allocator allocator) - : head_{0xFFFF'FFFF'0000'0000 | block_size} + : head_{0xFFFFFFFF00000000 | block_size} , tail_{block_size} , steal_count_{block_size} - , steal_tail_{0xFFFF'FFFF'0000'0000 | block_size} + , steal_tail_{0xFFFFFFFF00000000 | block_size} , ring_buffer_(block_size, allocator) {} diff --git a/include/exec/linux/io_uring_context.hpp b/include/exec/linux/io_uring_context.hpp index a030081f9..ca25be22a 100644 --- a/include/exec/linux/io_uring_context.hpp +++ b/include/exec/linux/io_uring_context.hpp @@ -1112,7 +1112,7 @@ namespace experimental::execution secs = (std::max) (secs, std::chrono::seconds{0}); dur = STDEXEC::__clamp(dur, std::chrono::nanoseconds{0}, - std::chrono::nanoseconds{999'999'999}); + std::chrono::nanoseconds{999999999}); return __kernel_timespec{secs.count(), dur.count()}; } # else @@ -1130,11 +1130,11 @@ namespace experimental::execution __nsec -= __sec; __nsec = STDEXEC::__clamp(__nsec, std::chrono::nanoseconds{0}, - std::chrono::nanoseconds{999'999'999}); + std::chrono::nanoseconds{999999999}); __timerspec.it_value.tv_sec += __sec.count(); __timerspec.it_value.tv_nsec = __nsec.count(); STDEXEC_ASSERT(0 <= __timerspec.it_value.tv_nsec - && __timerspec.it_value.tv_nsec < 1'000'000'000); + && __timerspec.it_value.tv_nsec < 1000000000); return __timerspec; } # endif diff --git a/include/exec/windows/filetime_clock.hpp b/include/exec/windows/filetime_clock.hpp index 7375e7e83..bf3fccfe8 100644 --- a/include/exec/windows/filetime_clock.hpp +++ b/include/exec/windows/filetime_clock.hpp @@ -27,7 +27,7 @@ namespace experimental::execution::__win32 { public: using rep = std::int64_t; - using ratio = std::ratio<1, 10'000'000>; // 100ns + using ratio = std::ratio<1, 10000000>; // 100ns using duration = std::chrono::duration; static constexpr bool is_steady = false; diff --git a/include/stdexec/__detail/__config.hpp b/include/stdexec/__detail/__config.hpp index f55a2b871..9281bd807 100644 --- a/include/stdexec/__detail/__config.hpp +++ b/include/stdexec/__detail/__config.hpp @@ -599,7 +599,7 @@ namespace STDEXEC #endif #if __has_include() && \ - (defined(__cpp_lib_memory_resource) && __cpp_lib_memory_resource >= 2016'03L) + (defined(__cpp_lib_memory_resource) && __cpp_lib_memory_resource >= 201603L) # define STDEXEC_NO_STDCPP_MEMORY_RESOURCE() 0 #else # define STDEXEC_NO_STDCPP_MEMORY_RESOURCE() 1 From 8d4e20a268f6915e246e4a6471a3fb58d955ab11 Mon Sep 17 00:00:00 2001 From: guptapratykshh Date: Sun, 19 Apr 2026 09:53:52 +0530 Subject: [PATCH 2/2] fix: revert unnecessary digit separator changes in non-preprocessor code clang-scan-deps only parses #if/#else, #include, and import directives, so digit separators in regular C++ code do not affect module scanning. Only the __config.hpp change (in a #if directive) is necessary. Signed-off-by: Pratyksh Gupta --- include/exec/detail/bwos_lifo_queue.hpp | 4 ++-- include/exec/linux/io_uring_context.hpp | 6 +++--- include/exec/windows/filetime_clock.hpp | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/exec/detail/bwos_lifo_queue.hpp b/include/exec/detail/bwos_lifo_queue.hpp index 417708b9c..789662e70 100644 --- a/include/exec/detail/bwos_lifo_queue.hpp +++ b/include/exec/detail/bwos_lifo_queue.hpp @@ -397,10 +397,10 @@ namespace experimental::execution::bwos template lifo_queue::block_type::block_type(std::size_t block_size, Allocator allocator) - : head_{0xFFFFFFFF00000000 | block_size} + : head_{0xFFFF'FFFF'0000'0000 | block_size} , tail_{block_size} , steal_count_{block_size} - , steal_tail_{0xFFFFFFFF00000000 | block_size} + , steal_tail_{0xFFFF'FFFF'0000'0000 | block_size} , ring_buffer_(block_size, allocator) {} diff --git a/include/exec/linux/io_uring_context.hpp b/include/exec/linux/io_uring_context.hpp index ca25be22a..a030081f9 100644 --- a/include/exec/linux/io_uring_context.hpp +++ b/include/exec/linux/io_uring_context.hpp @@ -1112,7 +1112,7 @@ namespace experimental::execution secs = (std::max) (secs, std::chrono::seconds{0}); dur = STDEXEC::__clamp(dur, std::chrono::nanoseconds{0}, - std::chrono::nanoseconds{999999999}); + std::chrono::nanoseconds{999'999'999}); return __kernel_timespec{secs.count(), dur.count()}; } # else @@ -1130,11 +1130,11 @@ namespace experimental::execution __nsec -= __sec; __nsec = STDEXEC::__clamp(__nsec, std::chrono::nanoseconds{0}, - std::chrono::nanoseconds{999999999}); + std::chrono::nanoseconds{999'999'999}); __timerspec.it_value.tv_sec += __sec.count(); __timerspec.it_value.tv_nsec = __nsec.count(); STDEXEC_ASSERT(0 <= __timerspec.it_value.tv_nsec - && __timerspec.it_value.tv_nsec < 1000000000); + && __timerspec.it_value.tv_nsec < 1'000'000'000); return __timerspec; } # endif diff --git a/include/exec/windows/filetime_clock.hpp b/include/exec/windows/filetime_clock.hpp index bf3fccfe8..7375e7e83 100644 --- a/include/exec/windows/filetime_clock.hpp +++ b/include/exec/windows/filetime_clock.hpp @@ -27,7 +27,7 @@ namespace experimental::execution::__win32 { public: using rep = std::int64_t; - using ratio = std::ratio<1, 10000000>; // 100ns + using ratio = std::ratio<1, 10'000'000>; // 100ns using duration = std::chrono::duration; static constexpr bool is_steady = false;