From e6d6ea3bd3806d80df74d117641e8f0d67eb2465 Mon Sep 17 00:00:00 2001 From: hypr2771 Date: Fri, 10 Apr 2026 13:00:51 +0700 Subject: [PATCH 1/2] chore: Log when service fails to instantiate --- .../apache/felix/scr/impl/manager/SingleComponentManager.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java b/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java index 9a61a98c55..d58807de43 100644 --- a/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java +++ b/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java @@ -928,6 +928,10 @@ public S getService( final Bundle bundle, final ServiceRegistration serviceRe return null; } + } catch (Throwable error){ + getLogger().log(Level.ERROR, + "Failed to create service from bundle", + error); } finally { From c032c81d607fcd2908b363da215bb1ab2d66fe5f Mon Sep 17 00:00:00 2001 From: hypr2771 Date: Fri, 10 Apr 2026 17:47:48 +0700 Subject: [PATCH 2/2] chore: Log when service fails to instantiate Missing `return` statement --- .../apache/felix/scr/impl/manager/SingleComponentManager.java | 1 + 1 file changed, 1 insertion(+) diff --git a/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java b/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java index d58807de43..a78937f815 100644 --- a/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java +++ b/scr/src/main/java/org/apache/felix/scr/impl/manager/SingleComponentManager.java @@ -932,6 +932,7 @@ public S getService( final Bundle bundle, final ServiceRegistration serviceRe getLogger().log(Level.ERROR, "Failed to create service from bundle", error); + return null; } finally {