signInWithProvider argument mismatch

[ThaNarie]

I'm getting an argument mismatch on the signInWithProvider function, expected 4, received 2.
I'm using the v3 branch.

The Java code expects 4 arguments (3 + callback/promise).

react-native-firestack/android/src/main/java/io/fullstack/firestack/auth/FirestackAuth.java

Line 161 in 8db8b50

public void signInWithProvider(final String provider, final String authToken, final String authSecret, final Callback callback) {

But the JS code sends an object as first argument.

react-native-firestack/lib/modules/auth/index.js

Line 154 in 8db8b50

return promisify('signInWithProvider', FirestackAuth)(credential);

The link function seems to be correctly updated:

react-native-firestack/lib/modules/auth/index.js

Line 137 in 8db8b50

return promisify('link', FirestackAuth, 'auth/')(credential.provider, credential.token, credential.secret);

Changing the code to this seems to work:

signInWithCredential(credential: any): Promise<Object> {
  return promisify('signInWithProvider', FirestackAuth)(credential.provider, credential.token, credential.secret);
}

[abcd-ca]

@ThaNarie This fixed it for me too, thanks. It should be accessToken in the JavaScript and in the Java as that's what it is in iOS and Web SDK. I've included this in my pull request (with docs updated for authToken too)