Skip to content

fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269

Open
Martinfx wants to merge 1 commit intoARM-software:mainfrom
Martinfx:max-freeebsd-fix-ncpu
Open

fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)#1269
Martinfx wants to merge 1 commit intoARM-software:mainfrom
Martinfx:max-freeebsd-fix-ncpu

Conversation

@Martinfx
Copy link
Copy Markdown
Contributor

@Martinfx Martinfx commented Mar 12, 2026

No description provided.

@gunes-arm
Copy link
Copy Markdown
Contributor

gunes-arm commented Mar 16, 2026

Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately.

@gunes-arm
Copy link
Copy Markdown
Contributor

gunes-arm commented Mar 16, 2026

@Martinfx I also suggest the following commit and pull request title:

fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)

@Martinfx Martinfx force-pushed the max-freeebsd-fix-ncpu branch from d90184d to 97df729 Compare March 16, 2026 13:02
@Martinfx Martinfx changed the title fix: detect hw.ncpu for FreeBSD fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R) Mar 16, 2026
@Martinfx
Copy link
Copy Markdown
Contributor Author

Martinfx commented Mar 16, 2026 •
edited
Loading

Hi @Martinfx , Can you sign-off your commit please. We forgot it in the last PR unfortunately.

ok. no problem.

@gunes-arm
Copy link
Copy Markdown
Contributor

gunes-arm commented Mar 16, 2026

@Martinfx clang-format hook in the pre-commit failed. You'll need to run that pre-commit hook.

gunes-arm
gunes-arm requested changes Mar 16, 2026
View reviewed changes
@Martinfx Martinfx force-pushed the max-freeebsd-fix-ncpu branch from 5e831a8 to fad3d65 Compare March 24, 2026 17:55
@Martinfx Martinfx requested a review from gunes-arm March 24, 2026 17:57
@Martinfx Martinfx force-pushed the max-freeebsd-fix-ncpu branch 3 times, most recently from 2d8057c to bdadbf6 Compare March 24, 2026 18:26
@Martinfx
Copy link
Copy Markdown
Contributor Author

Martinfx commented Mar 25, 2026

@gunes-arm sysconf(_SC_NPROCESSORS_ONLN); is also FreeBSD and for OpenBSD. AT_NCPUS is not in OpenBSD elf_aux_info

@Martinfx
Copy link
Copy Markdown
Contributor Author

Martinfx commented Mar 29, 2026

Hi, @gunes-arm , it is ok ?

gunes-arm
gunes-arm reviewed Mar 30, 2026
View reviewed changes
gunes-arm
gunes-arm reviewed Mar 30, 2026
View reviewed changes
@Martinfx Martinfx requested a review from gunes-arm April 5, 2026 23:55
gunes-arm
gunes-arm requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Martinfx , thanks for your fixes. It looks good except a few minor things. You should also squash your commits.

src/common/cpuinfo/CpuInfo.cpp
#elif (defined(__APPLE__)) && defined(__aarch64__)
#include <sys/sysctl.h>
#include <sys/types.h>
#elif (defined(__OpenBSD__) || defined(__FreeBSD__))
Copy link
Copy Markdown
Contributor

@gunes-arm gunes-arm Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(defined(__OpenBSD__) || defined(__FreeBSD__)) && defined(__aarch64__)

gunes-arm
gunes-arm reviewed Apr 7, 2026
View reviewed changes
@Martinfx Martinfx requested a review from gunes-arm April 7, 2026 18:08
@Martinfx
fix: Detection of HW caps and Num Cpus for FreeBSD(R) and OpenBSD(R)
d9f0a9c 
Signed-off-by: Martin Filla <freebsd@sysctl.cz>
@Martinfx Martinfx force-pushed the max-freeebsd-fix-ncpu branch from 20a4498 to d9f0a9c Compare April 7, 2026 18:12
gunes-arm
gunes-arm requested changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gunes-arm gunes-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

@Martinfx
Copy link
Copy Markdown
Contributor Author

Martinfx commented Apr 7, 2026

I guess there is one more remaining comment to be addressed: https://github.com/ARM-software/ComputeLibrary/pull/1269/changes#r3044146937

Yes. I reacted for comment: The problem with aarch64 is here #1274. Is amd64 support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunes-arm gunes-arm gunes-arm requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Martinfx @gunes-arm