fix: allow cleartext traffic#2009
Conversation
This comment has been minimized.
This comment has been minimized.
Greptile SummaryThis PR fixes cleartext HTTP traffic support by adding Confidence Score: 5/5Safe to merge — the change correctly fixes cleartext traffic and removes a non-functional wildcard domain entry. All new findings are P2 (redundant attribute). All previously raised concerns (global cleartext scope, multiple application elements) were already discussed in prior threads. The wildcard domain that was removed was never a valid Android NSC pattern, so the functional impact of removing it is zero. The net result is a working cleartext config. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[HTTP Request] --> B{android:networkSecurityConfig set?}
B -- Yes --> C[Evaluate network_security_config.xml]
B -- No --> D[Use android:usesCleartextTraffic attribute]
C --> E{domain-config match?}
E -- Yes --> F[Use domain-config cleartextTrafficPermitted]
E -- No --> G[Use base-config]
G --> H[cleartextTrafficPermitted=true]
H --> I[✅ Cleartext Allowed]
F --> I
D --> J[usesCleartextTraffic=true]
J --> I
style I fill:#90EE90
style H fill:#90EE90
style J fill:#lightgray,stroke:#aaa
Reviews (6): Last reviewed commit: "fix: cordova issue" | Re-trigger Greptile |
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
d92dc86 to
9bd7c1b
Compare
No description provided.