uploaders/pulp: parallel chunks, direct artifacts#220
Open
andrewlukoshko wants to merge 1 commit intoAlmaLinux:masterfrom
Open
uploaders/pulp: parallel chunks, direct artifacts#220andrewlukoshko wants to merge 1 commit intoAlmaLinux:masterfrom
andrewlukoshko wants to merge 1 commit intoAlmaLinux:masterfrom
Conversation
Member
andrewlukoshko
commented
Apr 6, 2026
- Replace sequential filesplit-based disk splitting with parallel ThreadPoolExecutor chunk uploads using byte-range reads via temp files
- Add direct artifact creation via ArtifactsApi.create() for files smaller than chunk_size, bypassing the 3-step upload+commit flow
- Eliminate redundant SHA256 hashing: file is now hashed once in upload_single_file and the hash is passed through _send_file and _commit_upload (was hashed 3 times per upload)
- Add per-file upload timing logs at INFO level for all three upload paths (direct artifact, single chunk, multi-chunk)
- Remove filesplit dependency from requirements.txt
- Add 5 new tests: direct artifact creation, parallel chunk upload, chunk error propagation, and timing log verification for both paths
- Replace sequential filesplit-based disk splitting with parallel ThreadPoolExecutor chunk uploads using byte-range reads via temp files - Add direct artifact creation via ArtifactsApi.create() for files smaller than chunk_size, bypassing the 3-step upload+commit flow - Eliminate redundant SHA256 hashing: file is now hashed once in upload_single_file and the hash is passed through _send_file and _commit_upload (was hashed 3 times per upload) - Add per-file upload timing logs at INFO level for all three upload paths (direct artifact, single chunk, multi-chunk) - Remove filesplit dependency from requirements.txt - Add 5 new tests: direct artifact creation, parallel chunk upload, chunk error propagation, and timing log verification for both paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.