Sync eng/common directory with azure-sdk-tools for PR 14918#46184
Open
Sync eng/common directory with azure-sdk-tools for PR 14918#46184
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs the eng/common README verification script with the corresponding update from azure-sdk-tools, ensuring doc-warden is installed from the Azure Artifacts Python feed during README validation runs.
Changes:
- Add a DevOps PyPI feed URL constant for package installation.
- Update the
pip install doc-wardenstep to use--index-urlpointing at that feed (and adjust the failure log message accordingly).
eng/common/scripts/Verify-Readme.ps1
Outdated
| exit 1 | ||
| } | ||
|
|
||
| Write-Host "pip install doc-warden==$DocWardenVersion --quiet" |
There was a problem hiding this comment.
The Write-Host message no longer matches the command being executed: it logs pip install doc-warden==... --quiet, but the actual command includes --index-url $FeedUrl. This makes pipeline logs misleading when debugging install failures. Update the Write-Host text to include the index URL (or build the full command once and reuse it for both logging and execution).
Suggested change
| Write-Host "pip install doc-warden==$DocWardenVersion --quiet" | |
| Write-Host "pip install doc-warden==$DocWardenVersion --quiet --index-url $FeedUrl" |
azure-sdk
force-pushed
the
sync-eng/common-install-docwarden-from-feed-14918
branch
from
ef00c38 to
b3b42f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14918 See eng/common workflow