test: use top-level import in SignButton tests#458
Merged
gabitoesmiapodo merged 1 commit intodevelopfrom Apr 10, 2026
Merged
Conversation
Replace per-test dynamic imports with a standard static import, matching the pattern used in TransactionButton and SwitchNetwork tests. Closes #455
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns SignButton test import style with other shared component tests by replacing per-test dynamic imports with a single top-level static import, simplifying the test bodies.
Changes:
- Switch from per-test
await import('./SignButton')to a single top-levelimport SignButton from './SignButton'. - Remove unnecessary
asyncfrom the affected test callbacks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #455
SignButton tests used per-test dynamic imports (
await import('./SignButton')) unlike the comparable TransactionButton and SwitchNetwork tests, which use standard top-level static imports. This aligns the import pattern for consistency.Changes
await import('./SignButton')calls with a single top-levelimport SignButton from './SignButton'asyncfrom all 4 test callbacks since they no longer containawaitAcceptance criteria
Test plan
Automated tests
Modified:
src/components/sharedComponents/SignButton.test.tsxRun:
pnpm test src/components/sharedComponents/SignButton.test.tsxManual verification
No manual steps required.
Breaking changes
None.
Screenshots
None.
Checklist