feat: state machine for scrape task producer state mgmt#115
Open
extreme4all wants to merge 4 commits intodevelopfrom
Open
feat: state machine for scrape task producer state mgmt#115extreme4all wants to merge 4 commits intodevelopfrom
extreme4all wants to merge 4 commits intodevelopfrom
Conversation
…factor core logic
extreme4all
changed the title
added 3 commits
April 10, 2026 23:21
…actor state management
…e test coverage for invalid transitions
| possible_ban=ctx.possible_ban, | ||
| confirmed_ban=ctx.confirmed_ban, | ||
| or_none=state == ScrapeState.NORMAL, | ||
| first_date=ctx.first_date, |
Contributor
There was a problem hiding this comment.
What's ctx? Can we just spell it out or
| fp.reset_for_new_day(max_days) | ||
| state = scraper_sm.handle(ctx, state, ScrapeEvent.NEW_DAY) | ||
|
|
||
| if state == ScrapeState.DONE: |
Contributor
There was a problem hiding this comment.
I like this approach
| transitions: dict[tuple[S, E], tuple[S, Action]] = field(default_factory=dict) | ||
|
|
||
| def add_transition( | ||
| self, from_state: S, event: E, to_state: S, func: Action |
Contributor
There was a problem hiding this comment.
Isn't S from state and the same var S to state going to cause an issue?
| # fmt: off | ||
| @scraper_sm.transition(ScrapeState.CONFIRMED_BAN, ScrapeEvent.NEXT_STEP, ScrapeState.DONE) | ||
| # fmt: on | ||
| def to_done(ctx: ScraperCtx) -> None: |
Contributor
There was a problem hiding this comment.
Why is done no ban state?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces imperative FetchParams mutation with generic state machine. Good separation: sm.py (generic engine), structs.py (enums/context), states.py (transition declarations), core.py (orchestration). ~120 lines cut from core.
Summary
Refactor scrape task producer state management from mutable
FetchParamsto an explicit state machine pattern.Changes
sm.py):StateMachine[S, E, C]with enum states/events, context object, decorator-based transition registration.structs.py):ScrapeStateenum (NORMAL → POSSIBLE_BAN → CONFIRMED_BAN → DONE),ScrapeEventenum (FETCH_MORE, REDUCE_DAYS, NEXT_STEP, NEW_DAY),ScraperCtxdataclass replacingFetchParams.states.py): All state transitions and side effects via@scraper_sm.transitiondecorators.core.py): Replacedetermine_fetch_params(mutation) withdetermine_event(pure) +scraper_sm.handle(transition). Removerun_async/runwrappers, inlinemain()setup.State flow
Each state narrows the date window (REDUCE_DAYS) until exhausted, then advances (NEXT_STEP). FETCH_MORE pages via cursor.
Notes
fetch_moreuses three decorators (one per state → self) as a workaround for missing self-transition concept in the generic SM. Consider addingtransition_to_selfor allowingto_state=Noneto mean "stay."