FIREFLY-1979: Fix SPHEREx tool not showing mosaic results#1937
Merged
jaladh-singhal merged 1 commit intodevfrom Apr 13, 2026
Merged
FIREFLY-1979: Fix SPHEREx tool not showing mosaic results#1937jaladh-singhal merged 1 commit intodevfrom
jaladh-singhal merged 1 commit intodevfrom
Conversation
Contributor
|
it took me several tries and a 'new private window' but i got it to work! yay! |
loitly
approved these changes
Apr 13, 2026
Contributor
loitly
left a comment
There was a problem hiding this comment.
This addresses the issue in Firefly when the result is missing a mime-type. Looks good to merge.
I also suggest notifying the service provider to include the mime-type (application/fits) so it can be handled correctly by other clients as well.
16aa34f to
3a9135a
Compare
… mime type FIREFLY-1979: Apply PR feedback
3a9135a to
991d894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-1979
The bug was happening because UWS results don't have mimeType attribute so we determine it when loading job results. The mimeType determination logic didn't factor in that compression ext
.gzmaybe present which is the case for updated Mosaic tool.Testing
https://firefly-1979-mosaic-results-bug.irsakubedev.ipac.caltech.edu/applications/spherex/
Submit a mosaic tool job (I did Dobashi 2438, 1arcsec x 1arcsec, default params). On job completion, the resulting image should show up on the right as pinned image.