Skip to content

FIREFLY-1979: Fix SPHEREx tool not showing mosaic results#1937

Merged
jaladh-singhal merged 1 commit intodevfrom
FIREFLY-1979-mosaic-results-bug
Apr 13, 2026
Merged

FIREFLY-1979: Fix SPHEREx tool not showing mosaic results#1937
jaladh-singhal merged 1 commit intodevfrom
FIREFLY-1979-mosaic-results-bug

Conversation

@jaladh-singhal
Copy link
Copy Markdown
Member

Fixes FIREFLY-1979

The bug was happening because UWS results don't have mimeType attribute so we determine it when loading job results. The mimeType determination logic didn't factor in that compression ext .gz maybe present which is the case for updated Mosaic tool.

Testing

https://firefly-1979-mosaic-results-bug.irsakubedev.ipac.caltech.edu/applications/spherex/

Submit a mosaic tool job (I did Dobashi 2438, 1arcsec x 1arcsec, default params). On job completion, the resulting image should show up on the right as pinned image.

@jaladh-singhal jaladh-singhal requested a review from loitly April 11, 2026 00:30
@jaladh-singhal jaladh-singhal self-assigned this Apr 11, 2026
@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Apr 11, 2026

it took me several tries and a 'new private window' but i got it to work! yay!

Copy link
Copy Markdown
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the issue in Firefly when the result is missing a mime-type. Looks good to merge.

I also suggest notifying the service provider to include the mime-type (application/fits) so it can be handled correctly by other clients as well.

@jaladh-singhal jaladh-singhal force-pushed the FIREFLY-1979-mosaic-results-bug branch from 16aa34f to 3a9135a Compare April 13, 2026 21:09
@jaladh-singhal jaladh-singhal force-pushed the FIREFLY-1979-mosaic-results-bug branch from 3a9135a to 991d894 Compare April 13, 2026 21:10
@jaladh-singhal jaladh-singhal merged commit 770070f into dev Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants