Skip to content

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 2 | Implement a linked list in Python#108

Open
Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Nataliia74:linkedList
Open

Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 2 | Implement a linked list in Python#108
Nataliia74 wants to merge 2 commits intoCodeYourFuture:mainfrom
Nataliia74:linkedList

Conversation

@Nataliia74
Copy link
Copy Markdown

@Nataliia74 Nataliia74 commented Feb 16, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Issue: Implement a linked list in Python 9

@Nataliia74 Nataliia74 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 16, 2026
Comment thread Sprint-2/implement_linked_list/linked_list.py
Comment thread Sprint-2/implement_linked_list/linked_list.py Outdated
Comment thread Sprint-2/implement_linked_list/linked_list.py Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 27, 2026
@Nataliia74 Nataliia74 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment on lines +45 to +52
# if node.previous is None:
# self.head = None
# self.tail = None
# else:
# self.tail = node.previous
# self.tail.next = None
# node.previous = None
# node.next = None
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete unused code to keep the code clean?

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants