Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Quote generator#1197
Open
Seti-Jemal wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 3 | Quote generator#1197Seti-Jemal wants to merge 4 commits intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Seti-Jemal
added
the
Needs Review
cjyuan
reviewed
Apr 14, 2026
Comment on lines
+506
to
+511
| displayQuote(); | ||
|
|
||
| // Change quote when button is clicked | ||
| document | ||
| .getElementById("new-quote") | ||
| .addEventListener("click", displayQuote); No newline at end of file |
Contributor
There was a problem hiding this comment.
Placing all the "run on load" code in one place is a good practice.
Would be even better to place the code
inside a function to make it clearer that "this is what runs when the page loads."
For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Apr 16, 2026
Comment on lines
+497
to
+516
| function setup() { | ||
| const quoteElement = document.getElementById("quote"); | ||
| const authorElement = document.getElementById("author"); | ||
|
|
||
|
|
||
| function displayQuote() { | ||
| const randomQuote = pickFromArray(quotes); | ||
|
|
||
| quoteElement.textContent = randomQuote.quote; | ||
| authorElement.textContent = randomQuote.author; | ||
| } | ||
|
|
||
| // Show a quote when page loads | ||
| displayQuote(); | ||
|
|
||
| // Change quote when button is clicked | ||
| document | ||
| .getElementById("new-quote") | ||
| .addEventListener("click", displayQuote); | ||
| } |
Contributor
There was a problem hiding this comment.
Indentation is off. Have you enabled "Format on save" on VSCode?
cjyuan
added
Reviewed
Seti-Jemal
added
Needs Review
Contributor
|
Look good! |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have completed the task.