-
-
Notifications
You must be signed in to change notification settings - Fork 283
Glasgow| 2026-ITP-Jan | Tuan Nguyen| Sprint 2 | Objects #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jacknguyen4438
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
Jacknguyen4438:Sprint-2-Objects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7a32b22
Doing the first part if the sprint 2
Jacknguyen4438 25def28
Making basic change and writing test
Jacknguyen4438 2ff2c05
finish the first part of implement
Jacknguyen4438 eaffafc
Commit for loop up
Jacknguyen4438 4d7b72c
finish the tally course work
Jacknguyen4438 9251977
For the final section for PR submission
Jacknguyen4438 33d17a2
Formatting all the file in sprint 2
Jacknguyen4438 db07953
Making change in the debug section
Jacknguyen4438 2a3243b
fixing the validation when array as a property value
Jacknguyen4438 ccce688
Final change before re submit
Jacknguyen4438 5cf4592
format the new test given by review for future study
Jacknguyen4438 fcfb3ef
Making change for resubmit for PR
Jacknguyen4438 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| function contains() {} | ||
| function contains(object, key) { | ||
| if (object === null || typeof object !== "object" || Array.isArray(object)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (Object.keys(object).length === 0) { | ||
| return false; | ||
| } | ||
|
|
||
| for (const item in object) { | ||
| if (item === key) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| module.exports = contains; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| function createLookup() { | ||
| function createLookup(pairs) { | ||
| // implementation here | ||
| let countryPair = {}; | ||
| for (const [country, currency] of pairs) { | ||
| countryPair[country] = currency; | ||
| } | ||
|
|
||
| return countryPair; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,18 @@ | ||
| function tally() {} | ||
| function tally(sumArray) { | ||
| if (!Array.isArray(sumArray)) { | ||
| throw new Error("Input musk be an array"); | ||
| } | ||
|
|
||
| if (sumArray.length === 0) return {}; | ||
|
|
||
| let totalSum = {}; | ||
| for (const item of sumArray) { | ||
| if (!Object.hasOwn(totalSum, item)) { | ||
| totalSum[item] = 1; | ||
| } else { | ||
| totalSum[item] += 1; | ||
| } | ||
| } | ||
|
cjyuan marked this conversation as resolved.
|
||
| return totalSum; | ||
| } | ||
| module.exports = tally; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.