Skip to content

London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Slideshow#1205

Open
miriamjorna wants to merge 5 commits intoCodeYourFuture:mainfrom
miriamjorna:Slideshow
Open

London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Slideshow#1205
miriamjorna wants to merge 5 commits intoCodeYourFuture:mainfrom
miriamjorna:Slideshow

Conversation

@miriamjorna
Copy link
Copy Markdown

@miriamjorna miriamjorna commented Apr 19, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Slideshow according to instructions, Level 2: different pictures with basic buttons to flip through them, automated.

@miriamjorna miriamjorna added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 19, 2026
@Edu-Vin Edu-Vin added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Apr 19, 2026
@Edu-Vin
Copy link
Copy Markdown

Edu-Vin commented Apr 19, 2026

Well done! I have a bit of feedback that could improve the solution:
Could you adjust the image so it doesn’t cover the full screen? It should be centred on the page with enough spacing around it and shouldn’t be too large. Also, the image shouldn’t be shrunk; it should remain clear and fully visible.

@Edu-Vin Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 19, 2026
@miriamjorna
Copy link
Copy Markdown
Author

miriamjorna commented Apr 19, 2026 •
edited
Loading

Oh thank you - I had seen the issue with the size and thought I had sorted it. Clearly not yet.

ETA: Fixed now. Thank you for your time!

@miriamjorna miriamjorna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 19, 2026
@Edu-Vin
Copy link
Copy Markdown

Edu-Vin commented Apr 19, 2026

It still isn't working. The issue is that you didn't link your stylesheet to your HTML file. Try it

@Edu-Vin Edu-Vin removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 19, 2026
@miriamjorna
Copy link
Copy Markdown
Author

miriamjorna commented Apr 20, 2026

Noooo you must be kidding? OMG that's embarrassing. Fixed that now!

@miriamjorna miriamjorna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@Edu-Vin
Copy link
Copy Markdown

Edu-Vin commented Apr 20, 2026

It happens. Welldone!

@Edu-Vin Edu-Vin added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miriamjorna @Edu-Vin