Glasgow | ITP-Jan-26 | Alasdair MacDonald | Sprint 3 | Coursework 3 implement and rewrite

[MacDonald91]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed the tasks required on the sprint, completed in one sitting due to catching up on course.

Questions

N/A

[cjyuan]

This exercise has a second part "2 Rewrite tests with Jest" ==> three more files to be updated.

[cjyuan]

In JavaScript, strings that represent valid numeric literals in the language can be safely converted to equivalent numbers. For examples, "0x02", "2.1", or "0002".

Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠");
getCardValue("2.1♠");
getCardValue("0002♠");

[cjyuan]

This exercise has a second part "2 Rewrite tests with Jest" ==> three more files to be updated.

You also need to update the .test.js file in Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest.

[cjyuan]

You need to revert the change made to package.json in the top-level folder (or else the validation bot will keep complaining).

One way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567.
The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

[cjyuan]

Lines 32, 34, 85 are merge conflict markers.

Lines 33 is from one source and lines 35 to 84 are from another source. You need to

1. Decide which lines of code you want to keep.
2. Delete the markers (on the lines I mentioned).

[cjyuan]

All good now.