Sheffield| 26-ITP-Jan| Mona- Eltantawy | Sprint 3| Sprint3 /practice tdd#1292
Open
Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Sheffield| 26-ITP-Jan| Mona- Eltantawy | Sprint 3| Sprint3 /practice tdd#1292Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Mona-Eltantawy
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Apr 16, 2026
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| expect(getOrdinalNumber(14)).toEqual("14th"); | ||
| }); No newline at end of file |
Contributor
There was a problem hiding this comment.
I'd be expecting an additional test here for 11, 12, 13 as they are explicitly different behaviours
Author
There was a problem hiding this comment.
I fixed the function implement to pass all the tests
Poonam-raj
reviewed
Apr 16, 2026
Contributor
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
The tests you have written and your solutions look great. I did spot a missing test for getOrdinalNumber and I can't see the solution for getOrdinalNumber - is this a missing file that needs to be committed to this branch?
Poonam-raj
added
Reviewed
Mona-Eltantawy
added
the
Needs Review
Poonam-raj
reviewed
Apr 20, 2026
Contributor
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Thank you for the changes - sorry for the delay in reviewing
Poonam-raj
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist