Skip to content

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3 | Coursework practice tdd#1294

Open
Ayogit1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Ayogit1:coursework-sprint-3-practice-tdd
Open

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3 | Coursework practice tdd#1294
Ayogit1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Ayogit1:coursework-sprint-3-practice-tdd

Conversation

@Ayogit1
Copy link
Copy Markdown

@Ayogit1 Ayogit1 commented Apr 18, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Coursework sprint 3 practice tdd

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
cjyuan
cjyuan reviewed Apr 19, 2026
View reviewed changes
Comment thread Sprint-3/2-practice-tdd/get-ordinal-number.js Outdated
Comment thread Sprint-3/2-practice-tdd/get-ordinal-number.test.js Outdated
Comment thread Sprint-3/2-practice-tdd/repeat-str.js Outdated
Comment thread Sprint-3/2-practice-tdd/repeat-str.test.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 19, 2026
@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 20, 2026

Can you also address #1294 (comment) ?

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 20, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 20, 2026

Looks good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ayogit1 @cjyuan