feat(cogstack-cohorter): Add helm chart for cogstack-cohorter#75
feat(cogstack-cohorter): Add helm chart for cogstack-cohorter#75jocelyneholdbrook wants to merge 3 commits intomainfrom
Conversation
…d workflow since it is not available via OCI
|
|
||
| - name: Add Helm repositories | ||
| run: | | ||
| helm repo add ollama https://otwld.github.io/ollama-helm/ |
There was a problem hiding this comment.
You can add these to .github/workflows/linters/ct.yaml, to keep it consistent
| @@ -0,0 +1,27 @@ | |||
| apiVersion: v2 | |||
| name: cogstack-cohorter | |||
There was a problem hiding this comment.
Just for the warning - I believe that this will publish to cogstack-cohorter in dockerhub, and you have to put the name in here to cogstack-cohorter-helm if you want it to go there.
I think you're lucky for cohorter that you dont have one image that already has the name taken, so I'm fine if you want to publish the helm chart to cogstack-cohorter.
For detail, I think the pattern is that companies have a separate helm organisation in dockerhub is how they get away with nice names.
I could 100% be wrong on this though! I'd love to be corrected and it let me use nicer names for everything.
alhendrickson
left a comment
alhendrickson
left a comment
There was a problem hiding this comment.
Approved if you want to merge it and publish it out.
I think the main comment would be if you can redo some based on the output of helm create .., which should generate a bunch of other stuff like the test, httproute etc. Convention seems to be keep it all super standardised
|
|
||
| - Kubernetes 1.21+ | ||
| - Helm 3.10+ | ||
| - A storage class that supports `ReadWriteOnce` PVCs |
There was a problem hiding this comment.
I'd probably remove this line, like I'd assume k8s has RWO
| pathType: ImplementationSpecific | ||
| tls: [] | ||
|
|
||
| autoscaling: |
There was a problem hiding this comment.
Move under the webapp?
| global: | ||
| imagePullSecrets: [] | ||
|
|
||
| nameOverride: "" |
There was a problem hiding this comment.
Hey for all these -
Can you update the values.yaml, to match the original one that helm create would generate? Basically looking to get all the comments and stuff exactly as they are from the default generated one
| {{- end }} | ||
| {{- end }} | ||
| {{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}} | ||
| apiVersion: networking.k8s.io/v1 |
There was a problem hiding this comment.
Can you regenerate this one from the helm create .. command instead? It shouldnt need all the (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion)) }} stuff and be a lot simpler here.
Potentially you should update helm, if you think it is from there already? I have 4.1.4, from the dev container setup.
I'd want to keep everything as default and standard as possible
alhendrickson
left a comment
alhendrickson
left a comment
There was a problem hiding this comment.
Well - I'd approve if it passed the check anyway!
------------------------------------------------------------------------------------------------------------------------
==> Logs of container cogstack-cohorter-helm-z581pqgk5y-webapp-58587cd997-fcndf
------------------------------------------------------------------------------------------------------------------------
[webapp] ERROR: No data found at /usr/src/app/server/data.
[webapp] Mount a directory containing snomed_terms.json (and related files)
[webapp] or snomed_terms_data.tar.gz via a Docker volume:
[webapp] -v /your/data:/usr/src/app/server/data
|
You can add a file like I'm, thinking its this one? I think the file suffix must be |
2 participants
No description provided.