Skip to content

Do not invoke disconnect callbacks on non-critical web socket transport error #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroffk merged 1 commit into from
Apr 10, 2026
+4 −4
Merged

Do not invoke disconnect callbacks on non-critical web socket transport error #3775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...socket/client/src/main/java/org/phoebus/core/websocket/client/WebSocketClientService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,12 @@ public void handleException(StompSession session, @Nullable StompCommand command
public void handleTransportError(StompSession session, Throwable exception) {
if (exception instanceof ConnectionLostException) {
logger.log(Level.WARNING, "Connection lost, will attempt to reconnect", exception);
if (disconnectCallback != null) {
disconnectCallback.run();
}
connect();
} else {
logger.log(Level.WARNING, "Handling transport exception", exception);
}
if (disconnectCallback != null) {
disconnectCallback.run();
logger.log(Level.WARNING, "Got transport exception", exception);
}
}
}
Expand Down
Loading