Skip to content

Guard against empty ResourceHandler in getFluid#229

Merged
rubensworks merged 1 commit intomaster-26from
copilot/add-resourcehandler-size-check
Apr 20, 2026
Merged

Guard against empty ResourceHandler in getFluid#229
rubensworks merged 1 commit intomaster-26from
copilot/add-resourcehandler-size-check

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

FluidUtil.getStack(fluidHandler, 0) crashes when the handler has zero slots. Added a size() > 0 guard so an empty handler returns FluidStack.EMPTY instead.

// Before
return fluidHandler != null ? FluidUtil.getStack(fluidHandler, 0) : FluidStack.EMPTY;

// After
return fluidHandler != null && fluidHandler.size() > 0 ? FluidUtil.getStack(fluidHandler, 0) : FluidStack.EMPTY;

@sonarqubecloud
Copy link
Copy Markdown

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 30.841% (-0.004%) from 30.845% — copilot/add-resourcehandler-size-check into master-26

@rubensworks rubensworks marked this pull request as ready for review April 20, 2026 16:36
@rubensworks rubensworks merged commit 4c576f3 into master-26 Apr 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants