Move chunk_size to argument and retry_on_failure = TRUE#879
Open
ldecicco-USGS wants to merge 17 commits intoDOI-USGS:developfrom
Open
Move chunk_size to argument and retry_on_failure = TRUE#879ldecicco-USGS wants to merge 17 commits intoDOI-USGS:developfrom
ldecicco-USGS wants to merge 17 commits intoDOI-USGS:developfrom
Conversation
Actually render slides
CRAN release v2.7.24
ldecicco-USGS
had a problem deploying
to
CI_config
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some testing, realized the "req_retry" function wasn't really doing much unless
retry_on_failure = TRUEwas set andhttr2::req_perform_iterativeneeds to haveon_error = "return"so that the retry actually gets triggered.Additionally, moved the chunking argument to a top level argument.