fix: render embeds in message list/history/search plain text output#18
Open
flarco wants to merge 1 commit intoDevRohit06:mainfrom
Open
fix: render embeds in message list/history/search plain text output#18flarco wants to merge 1 commit intoDevRohit06:mainfrom
flarco wants to merge 1 commit intoDevRohit06:mainfrom
Conversation
Discord bot messages often have empty content with all text in embeds (e.g. Healthchecks.io, Axiom). Three commands were affected: - message list: only printed msg.content, skipping embeds entirely - message history: same issue, also did not capture embeds in JSON - message search: only searched msg.content so embed-only messages never matched; also skipped embeds in plain text output Changes: - Capture full embed data (title, description, fields, footer, author) in all three commands - Append rendered embed content to each plain text output line in the format: [Title] | description | Field Name: value | (footer) - Fix message search to build searchable text from both content and all embed fields so embed-only messages are found - Fix message search --limit semantics: previously limited messages *scanned* (so --limit 10 meant only check 10 messages); now *scanned* (so --limit 10 meant only check 10 messages); nls messages scanned (default 500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Discord bot messages often have empty content with all text in embeds (e.g. Healthchecks.io, Axiom). Three commands were affected:
Changes
message list / message history:
message search: