Draft
Conversation
7 tasks
Contributor
oliwenmandiamond
left a comment
oliwenmandiamond
left a comment
There was a problem hiding this comment.
This looks good. Just think the variable name needs to be changed + need to add the config
| self.apple2 = Reference(apple2) | ||
| self.gap_energy_motor_converter = gap_energy_motor_converter | ||
| self.phase_energy_motor_converter = phase_energy_motor_converter | ||
| self.energy_gap_converter = energy_gap_coverter |
Contributor
There was a problem hiding this comment.
The name makes more sense if something like pol_gap_to_energy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2003
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}