Open
Conversation
Collaborator
Author
|
Hint: Check the new test |
sanguinariojoe
force-pushed
the
pointbreak
branch
from
9bb25e8 to
13ac794
Compare
Collaborator
Author
|
Apparently the test fails on MacOs... Checking... |
sanguinariojoe
force-pushed
the
pointbreak
branch
from
13ac794 to
f47d88a
Compare
Collaborator
Author
|
Everything is alright now. But I am finding some uninitialized values that might require a deeper analysis |
sanguinariojoe
force-pushed
the
pointbreak
branch
from
f47d88a to
26bad3b
Compare
Collaborator
Author
|
Well, it is more elusive than I thought. Tomorrow I am finding and fixing it |
sanguinariojoe
force-pushed
the
pointbreak
branch
from
269cc73 to
c17f015
Compare
Collaborator
Author
|
@RyanDavies19 , no more errors! Please take a look, and if it suffices just merge and feel free to implement MoorDynF alike line breaking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised, here you have the utilities to do lines breaking!
It is just the scaffolding (+ an API entry). All the stuff about configurations, triggers and so on is not implemented. Thus it is not fully fixing #378, but some work has to be done yet