feat: add password visibility toggle to password fields#6161
Open
akshitrawat21 wants to merge 3 commits intoFlowiseAI:mainfrom
Open
feat: add password visibility toggle to password fields#6161akshitrawat21 wants to merge 3 commits intoFlowiseAI:mainfrom
akshitrawat21 wants to merge 3 commits intoFlowiseAI:mainfrom
Conversation
- Add eye icon toggle to Input component for all password type fields - Add show/hide toggle to Old Password, New Password, Confirm New Password fields in Account Settings security section - Closes FlowiseAI#6160
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces password visibility toggling functionality across the application. It updates the generic Input component and the account settings page to include eye icons that allow users to mask or unmask password fields. A review comment points out a redundant conditional check in the getInputType function that can be simplified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6160
Inputcomponent for alltype='password'fields — covers Register page (Password & Confirm Password)Changes
packages/ui/src/ui-component/input/Input.jsx— addedshowPasswordstate,IconEye/IconEyeOffasendAdornmentwheninputParam.type === 'password'packages/ui/src/views/account/index.jsx— addedshowOldPassword,showNewPassword,showConfirmPasswordstates with eye icon toggles on eachOutlinedInputTest plan
/register— verify eye icon appears on Password and Confirm Password fieldsScreenshots