Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (23)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBump multiple package versions to 2.1.0, add corresponding 2.1.0 changelog entries (noting dependency bumps and a fix to exclude non-/dist files from sdk-effects distributions), and remove two Changeset markdown entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 12796e0
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/sdk-utilities/CHANGELOG.md`:
- Line 7: Replace the malformed changelog entry string "Updated dependencies
[]:" with a proper heading such as "Updated dependencies:" or, if there are
specific packages, replace the empty brackets with a comma-separated list of the
updated packages; locate the exact token "Updated dependencies []:" in
CHANGELOG.md and remove the empty square brackets or populate them with the
dependency names so the line reads correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 80c258cc-8a08-4435-80ff-d329f5cf4beb
📒 Files selected for processing (25)
.changeset/odd-parents-joke.mdpackages/davinci-client/CHANGELOG.mdpackages/davinci-client/package.jsonpackages/device-client/CHANGELOG.mdpackages/device-client/package.jsonpackages/journey-client/CHANGELOG.mdpackages/journey-client/package.jsonpackages/oidc-client/CHANGELOG.mdpackages/oidc-client/package.jsonpackages/protect/CHANGELOG.mdpackages/protect/package.jsonpackages/sdk-effects/iframe-manager/CHANGELOG.mdpackages/sdk-effects/iframe-manager/package.jsonpackages/sdk-effects/logger/CHANGELOG.mdpackages/sdk-effects/logger/package.jsonpackages/sdk-effects/oidc/CHANGELOG.mdpackages/sdk-effects/oidc/package.jsonpackages/sdk-effects/sdk-request-middleware/CHANGELOG.mdpackages/sdk-effects/sdk-request-middleware/package.jsonpackages/sdk-effects/storage/CHANGELOG.mdpackages/sdk-effects/storage/package.jsonpackages/sdk-types/CHANGELOG.mdpackages/sdk-types/package.jsonpackages/sdk-utilities/CHANGELOG.mdpackages/sdk-utilities/package.json
💤 Files with no reviewable changes (1)
- .changeset/odd-parents-joke.md
|
|
||
| ### Patch Changes | ||
|
|
||
| - Updated dependencies []: |
There was a problem hiding this comment.
Fix malformed dependency note formatting.
Line 7 includes empty brackets (Updated dependencies []:), which reads like a broken reference token in the published changelog.
Suggested fix
-- Updated dependencies []:
+- Updated dependencies:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - Updated dependencies []: | |
| - Updated dependencies: |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/sdk-utilities/CHANGELOG.md` at line 7, Replace the malformed
changelog entry string "Updated dependencies []:" with a proper heading such as
"Updated dependencies:" or, if there are specific packages, replace the empty
brackets with a comma-separated list of the updated packages; locate the exact
token "Updated dependencies []:" in CHANGELOG.md and remove the empty square
brackets or populate them with the dependency names so the line reads correctly.
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (15.67%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
===========================================
- Coverage 70.90% 15.67% -55.24%
===========================================
Files 53 154 +101
Lines 2021 26666 +24645
Branches 377 1127 +750
===========================================
+ Hits 1433 4180 +2747
- Misses 588 22486 +21898 🚀 New features to boost your workflow:
|
Contributor
|
Deployed c27270d to https://ForgeRock.github.io/ping-javascript-sdk/pr-561/c27270d2729097a5b9e68237db49f43b0413f436 branch gh-pages in ForgeRock/ping-javascript-sdk |
Contributor
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-9.9 KB, -100.0%) ➖ No Changes➖ @forgerock/device-client - 9.9 KB 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
54cb938 to
fd536c9
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
fd536c9 to
12796e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/davinci-client@2.1.0
Minor Changes
#562
63e94aaThanks @ryanbas21! - Add QR code collector support to davinci-client#563
ec39137Thanks @ancheetah! - Support both challenge polling and continue polling in DaVinciPatch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exportsUpdated dependencies [
ec39137,d849256]:@forgerock/sdk-request-middleware@2.1.0
Minor Changes
ec39137Thanks @ancheetah! - Support both challenge polling and continue polling in DaVinciPatch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/device-client@2.1.0
Patch Changes
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exports@forgerock/journey-client@2.1.0
Patch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exports#557
5fe2f41Thanks @ryanbas21! - ExtendJourneyClientConfigfromAsyncLegacyConfigOptionsso the same config object can be shared across journey-client, davinci-client, and oidc-clientclientId,scope,redirectUri, and other inherited properties are now accepted but ignored — a warning is logged when they are providedserverConfig.wellknownremains requiredUpdated dependencies [
ec39137,d849256]:@forgerock/oidc-client@2.1.0
Patch Changes
#564
15d5af3Thanks @ryanbas21! - Update interfaces and types that are missing from exportsUpdated dependencies [
ec39137,d849256]:@forgerock/iframe-manager@2.1.0
Patch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/sdk-logger@2.1.0
Patch Changes
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.@forgerock/sdk-oidc@2.1.0
Patch Changes
#555
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.Updated dependencies []:
@forgerock/storage@2.1.0
Patch Changes
#555
d849256Thanks @ancheetah! - Fixes files distributed in sdk-effects packages. Excludes files not in/distfolder.Updated dependencies []:
@forgerock/sdk-utilities@2.1.0
Patch Changes
@forgerock/protect@2.1.0
@forgerock/sdk-types@2.1.0
Summary by CodeRabbit
New Features
Bug Fixes
Chores