Update GetLogicalType() to support creating a List type for IList<T> columns in table functions#325
Merged
Giorgi merged 1 commit intoGiorgi:developfrom Apr 13, 2026
Conversation
…<T>` columns in table functions. Also fixes crash when DuckDB-internal list functions (e.g. `list_has_any`) operate on list columns from table functions. The root cause was that `duckdb_list_vector_set_size` was never called after writing child elements, so DuckDB didn't know the actual size of the child vector. Simple reads worked, but functions that presumably inspect the child vector's reported size would crash. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 24344417911Coverage increased (+0.03%) to 89.637%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes crash when DuckDB-internal list functions (e.g.
list_has_any) operate on list columns from table functions. The root cause was thatduckdb_list_vector_set_sizewas never called after writing child elements, so DuckDB didn't know the actual size of the child vector. Simple reads worked, but functions that presumably inspect the child vector's reported size would crash.