Skip to content

Add dual-path EdgeZero entry point with feature flag (PR 14) #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prk-Jr wants to merge 15 commits into
base: feature/edgezero-pr13-integration-provider-type-migration
Choose a base branch
from
Open

Add dual-path EdgeZero entry point with feature flag (PR 14) #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f5a984a
Add dual-path entry point with feature-flag dispatch and legacy_main …
prk-Jr Apr 13, 2026
a81b1d6
Fix clippy doc_markdown, fmt, and add warn log on flag-read failure
prk-Jr Apr 13, 2026
7d2f059
Add FinalizeResponseMiddleware and AuthMiddleware with golden header-…
prk-Jr Apr 13, 2026
4410813
Simplify EdgeError::internal call and fix comment accuracy in middleware
prk-Jr Apr 13, 2026
68ddcba
Revert anyhow direct dependency; use std::io::Error::other for EdgeEr…
prk-Jr Apr 13, 2026
8c9cb56
Implement TrustedServerApp with all routes via Hooks trait
prk-Jr Apr 13, 2026
5e30906
Fix app.rs spec gaps: remove double-Arc, move tsjs into catch-all, fi…
prk-Jr Apr 13, 2026
e1bce63
Clean up app.rs: remove gratuitous allocation, Box::pin inconsistency…
prk-Jr Apr 13, 2026
181d866
Reference legacy-cleanup issue in legacy_main comment
prk-Jr Apr 13, 2026
e8e0d9f
Fix lint issues
prk-Jr Apr 13, 2026
d3c2798
Pin edgezero dependencies to branch=main and bump toml to 1.1
prk-Jr Apr 13, 2026
a300109
Switch EdgeZero dispatch to dispatch_with_config, add routing log lines
prk-Jr Apr 13, 2026
86a44b6
Register explicit GET / and POST / routes to cover matchit root path gap
prk-Jr Apr 13, 2026
a48d956
Add trusted_server_config config store for local dev
prk-Jr Apr 13, 2026
dacc403
Address PR review findings in app.rs
prk-Jr Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"Bash(git status:*)",
"mcp__plugin_chrome-devtools-mcp_chrome-devtools__new_page",
"mcp__plugin_chrome-devtools-mcp_chrome-devtools__performance_stop_trace",
"mcp__plugin_chrome-devtools-mcp_chrome-devtools__evaluate_script",
"mcp__plugin_chrome-devtools-mcp_chrome-devtools__evaluate_script"
]
},
"enabledPlugins": {
Expand Down
46 changes: 26 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ config = "0.15.19"
cookie = "0.18.1"
derive_more = { version = "2.0", features = ["display", "error"] }
ed25519-dalek = { version = "2.2", features = ["rand_core"] }
edgezero-adapter-axum = { git = "https://github.com/stackpop/edgezero", rev = "170b74b", default-features = false }
edgezero-adapter-cloudflare = { git = "https://github.com/stackpop/edgezero", rev = "170b74b", default-features = false }
edgezero-adapter-fastly = { git = "https://github.com/stackpop/edgezero", rev = "170b74b", default-features = false }
edgezero-core = { git = "https://github.com/stackpop/edgezero", rev = "170b74b", default-features = false }
edgezero-adapter-axum = { git = "https://github.com/stackpop/edgezero", branch = "main", default-features = false }
edgezero-adapter-cloudflare = { git = "https://github.com/stackpop/edgezero", branch = "main", default-features = false }
edgezero-adapter-fastly = { git = "https://github.com/stackpop/edgezero", branch = "main", default-features = false }
edgezero-core = { git = "https://github.com/stackpop/edgezero", branch = "main", default-features = false }
Copy link
Copy Markdown
Collaborator

@aram356 aram356 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 wrench — Workspace deps pinned to branch = "main"

All four edgezero-* deps moved from rev = "170b74b" to branch = "main". Cargo.lock records the resolved commit, but anyone running cargo update will silently pull whatever is on upstream main that minute — CI/local builds become non-deterministic and create a supply-chain path from an external repo into prod.

Fix: pin to the specific upstream commit that introduced dispatch_with_config instead of a moving branch.

edgezero-adapter-axum       = { git = "https://github.com/stackpop/edgezero", rev = "<sha>", default-features = false }
edgezero-adapter-cloudflare = { git = "https://github.com/stackpop/edgezero", rev = "<sha>", default-features = false }
edgezero-adapter-fastly     = { git = "https://github.com/stackpop/edgezero", rev = "<sha>", default-features = false }
edgezero-core               = { git = "https://github.com/stackpop/edgezero", rev = "<sha>", default-features = false }

If upstream is unreleased, mirror the required change into a fork tag.

error-stack = "0.6"
fastly = "0.11.12"
fern = "0.7.1"
Expand All @@ -86,7 +86,7 @@ subtle = "2.6"
temp-env = "0.3.6"
tokio = { version = "1.49", features = ["sync", "macros", "io-util", "rt", "time"] }
tokio-test = "0.4"
toml = "1.0"
toml = "1.1"
url = "2.5.8"
urlencoding = "2.1"
uuid = { version = "1.18", features = ["v4"] }
Expand Down
Loading
Loading