Skip to content

UID2-6917 Add 20 concurrent requests restriction for /identity/map#1012

Open
swibi-ttd wants to merge 2 commits intomainfrom
swi-UID2-6917-add-20-concurrent-requests-restriction
Open

UID2-6917 Add 20 concurrent requests restriction for /identity/map#1012
swibi-ttd wants to merge 2 commits intomainfrom
swi-UID2-6917-add-20-concurrent-requests-restriction

Conversation

@swibi-ttd
Copy link
Copy Markdown
Contributor

  • Add our suggested limit of 20 concurrent requests for /identity/map endpoints
  • Fix Documentation Updates entry that was in the wrong quarter

Copy link
Copy Markdown
Collaborator

@genwhittTTD genwhittTTD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Sean. Few comments. Also I will open a thread about the level of detail in Doc Updates and copy you on it.


- The maximum request size is 1MB.
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch.
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch. You may send up to 20 batches in parallel.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say "can" rather than "may" here. We're not giving them permission, we're stating capabilities. (though per the description this is a recommendation? Either way it's not quite right. But we should be clear whether it's a recommendation or a requirement. Suggest:

Suggested change
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch. You may send up to 20 batches in parallel.
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch. We recommend sending no more than 20 batches in parallel.

Or if it's an even more firm recommendation, we could say:

Do not send more than 20 batches in parallel.

That also leaves me wondering why, though. If there's anything we can comfortably share it would be good. Very likely not but checking in case we could say something like this:

To avoid processing delays, do not send more than 20 batches in parallel.

That gives them a purpose. Though, again, it might be too much info.


- The maximum request size is 1MB.
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch.
- To map a large number of email addresses, phone numbers, or their respective hashes, send them in batches with a maximum of 5,000 items per batch. You may send up to 20 batches in parallel.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

:::

## Q1 2026
## Q2 2026
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only announce major documents, basically... not small fixes like this. Suggest just remove the new section (leave the fix of course since it's a correction to existing content). Though actually my comment applies to the Rate Limiting changes also.

If there's some specific reason we should include it, OK... but there have been many, many changes that we don't announce. I looked over the doc and appreciate that this isn't clear from the heading.

This is something I'll ask SW and KK about. I'll copy you on it. For now, your call.


The [POST /identity/map](../endpoints/post-identity-map.md) endpoint documentation has been updated with the following changes:

- Added a recommendation to send up to 20 /identity/map batches in parallel.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying in case you end up keeping it -- the way this is written it doesn't sound like a limit. It sounds like we're recommending sending lots. Suggest use the same rewording as on the other entries, if that makes sense.

Added a recommendation to send not more than 20 batches in parallel.

Something like that. But better we don't list a doc change this small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants