Add a workaround to custom_inclusive_scan_over_group#2275
Merged
ndgrigorian merged 3 commits intomasterfrom Apr 9, 2026
Merged
Add a workaround to custom_inclusive_scan_over_group#2275ndgrigorian merged 3 commits intomasterfrom
custom_inclusive_scan_over_group#2275ndgrigorian merged 3 commits intomasterfrom
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_52 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_53 ran successfully. |
ndgrigorian
reviewed
Apr 9, 2026
ndgrigorian
previously approved these changes
Apr 9, 2026
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
aside from possibility of changing which memory_order is used this LGTM
ndgrigorian
approved these changes
Apr 9, 2026
|
Array API standard conformance tests for dpctl=0.22.0dev1=py310h93fe807_54 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is IGC bug identified when using
custom_inclusive_scan_over_groupinside accumulator SYCL kernels on ARL GPU.The issue is that IGC incorrectly optimized the code, cause work-item=0 initialized
__scan_valwith zero instead ofidentityvalue.This PR proposes to implement a workaround which adds SYCL atomic fence. That works since the explicit memory fence prevents reordering/elimination, but leads to slight overhead.
Note, no new test added, since
test_tensor_accumulation.py::test_logcumsumexp_basicandtest_tensor_accumulation.py::test_cumulative_logsumexp_closed_form[fpdt0]already cover the issue and failed without the w/a in place.