Open
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
these are for various regressions
ndgrigorian
force-pushed
the
add-more-tests-for-interfaces
branch
from
757c278 to
d317543
Compare
antonwolfy
reviewed
Apr 9, 2026
| assert_equal(out.shape, tgtShape) | ||
|
|
||
|
|
||
| class TestRegression: |
Collaborator
There was a problem hiding this comment.
Would it be better to move them into test_regression.py to keep file alignment with NumPy?
Probably it would be easier to maintain later when we need to refresh them with the latest NumPy changes.
Comment on lines
2210
to
2211
| if size is None and dtype in (bool, int): | ||
| return dtype(ret) |
Collaborator
There was a problem hiding this comment.
Do we need to update that block also?
Is that expected?
np.int32 in (int, bool)
# Out: False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes adding more tests vendored from NumPy's
random/tests. These tests are specifically vendored from tests for regressions inRandomStateThe tests exposed some issues in
multinomial,permutation, andrandint, which were solved in the scope of this PR