Fix WebSocket connection header parameter in KalshiWebSocketClient#11
Open
harrodyuan wants to merge 1 commit intoKalshi:mainfrom
Open
Fix WebSocket connection header parameter in KalshiWebSocketClient#11harrodyuan wants to merge 1 commit intoKalshi:mainfrom
harrodyuan wants to merge 1 commit intoKalshi:mainfrom
Conversation
|
mine works with the old version "additional_headers" and not "extra_headers"; as the requirement file now has a fixed version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical issue in KalshiWebSocketClient caused by an upstream change in the websockets package, which now requires the extra_headers parameter to be explicitly passed.
Without this fix, the WebSocket connection fails and the example code cannot run. This patch updates the connect call to restore compatibility.
Tested locally and confirmed working.