Open
Conversation
sorairolake
force-pushed
the
feature/rust-crypto-traits
branch
from
5621739 to
f918a0b
Compare
Owner
|
Why do we need more than https://crates.io/crates/password-hash? |
|
As the author of both crates, I would suggest |
sorairolake
force-pushed
the
feature/rust-crypto-traits
branch
from
f918a0b to
b29b9d1
Compare
sorairolake
changed the title
password-hash feature
Contributor
Author
|
Sorry for the delay 🙇♂️ Based on #97 (comment), I removed the |
Keats
reviewed
Apr 12, 2026
|
|
||
| [features] | ||
| default = ["std", "zeroize"] | ||
| default = ["std", "zeroize", "password-hash"] |
Owner
There was a problem hiding this comment.
it probably shouldn't be part of the default feature
| #[cfg(feature = "password-hash")] | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| /// bcrypt context. | ||
| pub struct Bcrypt { |
Owner
There was a problem hiding this comment.
can that be used internally? a bit weird to have that just for the password-hash feature and this mean we duplicate the cost check
| salt: &[u8], | ||
| alg_id: Option<&str>, | ||
| version: Option<password_hash::Version>, | ||
| params: Self::Params, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements traits from the
kdfcrate and thepassword-hashcrate, and thePasswordHashstruct and thePasswordHashRefstruct from themcfcrate.These are implemented in crates such as
argon2andscrypton https://github.com/RustCrypto/password-hashes, and this pull request will allow this crate to use the same API as these crates.