Open
Conversation
Caching only the ghost cells won't work as RemoveGhostCells modifies the output. Only new arrays are modified using PedigreeIds
This reverts commit 9c93c21. There is no need for PVGeometryFilter anymore as removing HIDDENCELL is done in EAMExtract
Collaborator
Author
|
@jourdain Please review |
Collaborator
Author
|
Note that I had to update the input for the mappers (in my script) on the second render, otherwise I was seeing a crash at the second render: https://gitlab.kitware.com/danlipsa/quickview_optimize/-/commit/b3cc77daf462693b27a25b7daf8bbd79891aba57 I see a similar crash in Quickview, and it seems we don't do that there - but maybe I don't follow the code.
|
jourdain
reviewed
Apr 7, 2026
| def extract_avgs(vtk_data, array_names): | ||
| def extract_avgs(pv_data, array_names): | ||
| results = {} | ||
| vtk_data = servermanager.Fetch(pv_data) |
Collaborator
Author
There was a problem hiding this comment.
Oh, yes that is wrong. I still have to use the vtk_data.
Collaborator
Author
|
Seems there is an additional issue going on. I still get the crash if I update only the "trim". If I update both the trim and projection I don't get the crash (in my script). |
jourdain
reviewed
Apr 7, 2026
| geom_filter = self.source.views["atmosphere_data"] | ||
| geom_filter.Update() | ||
| data = geom_filter.GetOutput() | ||
| data = self.source.views["atmosphere_data"] |
jourdain
reviewed
Apr 7, 2026
| geom_filter = self.source.views["atmosphere_data"] | ||
| geom_filter.Update() | ||
| data = geom_filter.GetOutput() | ||
| data = self.source.views["atmosphere_data"] |
jourdain
reviewed
Apr 7, 2026
| def Update(self, data_file, conn_file): # force_reload | ||
| if self.data_reader.load(data_file, conn_file): | ||
| self.views["atmosphere_data"] = self.data_reader.vtk_geometry | ||
| self.views["atmosphere_data"] = self.data_reader.geometry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.