refactor: remove DREP and STAKE deposit constants from codebase#225
Open
Andre-Diamond wants to merge 1 commit intomainfrom
Open
refactor: remove DREP and STAKE deposit constants from codebase#225Andre-Diamond wants to merge 1 commit intomainfrom
Andre-Diamond wants to merge 1 commit intomainfrom
Conversation
Eliminated unused deposit constants from protocol-deposit-constants.ts and related files. Updated transaction handling to remove references to DREP_DEPOSIT_STRING and STAKE_KEY_DEPOSIT, simplifying the transaction logic in offchain.ts, retire.tsx, stake.tsx, and useTransaction.ts. This change enhances code clarity and reduces unnecessary complexity.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated unused deposit constants from protocol-deposit-constants.ts and related files. Updated transaction handling to remove references to DREP_DEPOSIT_STRING and STAKE_KEY_DEPOSIT, simplifying the transaction logic in offchain.ts, retire.tsx, stake.tsx, and useTransaction.ts. This change removes a bug and enhances code clarity and reduces unnecessary complexity.