test: add comprehensive tests for MinimaxAPIClient (0% -> 100% coverage)#75
Open
hell0gunawan wants to merge 2 commits intoMiniMax-AI:mainfrom
Open
test: add comprehensive tests for MinimaxAPIClient (0% -> 100% coverage)#75hell0gunawan wants to merge 2 commits intoMiniMax-AI:mainfrom
hell0gunawan wants to merge 2 commits intoMiniMax-AI:mainfrom
Conversation
Adds 16 unit tests covering: - Client initialization (api_key, host, session, headers) - _make_request method (success, 4xx, 5xx, API errors) - API error codes: 1004 (auth), 2038 (real-name), generic - Connection/timeout error handling - get() and post() helper methods Addresses issue MiniMax-AI#72: 'test: expand test coverage — only utils tested, server and client have zero tests'
- Test all 9 MCP tool functions: text_to_audio, list_voices, voice_clone, play_audio, generate_video, query_video_generation, text_to_image, music_generation, voice_design - Mock api_client for all API-dependent tests - Test success paths and error paths for each tool - Test both local and URL resource modes - 48 tests covering all tools with 90% server.py coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 16 unit tests covering the
MinimaxAPIClientclass — achieving 100% line coverage (up from 0%).What was tested
16 tests covering:
Coverage results
Addresses
Closes #72 —
test: expand test coverage — only utils tested, server and client have zero tests