fix: sync version and use context manager for file handle#77
Open
hell0gunawan wants to merge 1 commit intoMiniMax-AI:mainfrom
Open
fix: sync version and use context manager for file handle#77hell0gunawan wants to merge 1 commit intoMiniMax-AI:mainfrom
hell0gunawan wants to merge 1 commit intoMiniMax-AI:mainfrom
Conversation
- Sync __init__.py version: 0.0.17 -> 0.0.18 (matches pyproject.toml) - Use context manager for play_audio local file reading to prevent file handle leak (fixes MiniMax-AI#63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent fixes in one PR:
1. Version sync (#62)
__init__.py: 0.0.17 → 0.0.18pyproject.tomlversion (already 0.0.18)2. File handle leak fix (#63)
play_audio(): changedopen()to usewithcontext managerBoth are small, isolated, low-risk fixes with no chance of breaking existing functionality.
Changes
Addresses