Make events more consistent and add missing register methods#256
Open
DanyGames2014 wants to merge 1 commit intoModificationStation:developfrom
Open
Make events more consistent and add missing register methods#256DanyGames2014 wants to merge 1 commit intoModificationStation:developfrom
DanyGames2014 wants to merge 1 commit intoModificationStation:developfrom
Conversation
thecatcore
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntityRegistertoEntityRegisterEventKeyBindingRegisterEvent.registermethodBlockEntityRendererRegisterEvent.registermethodBlockEntityRegisterEvent.registeroverload usingIdentifierEntityRegisterEvent.registeroverload using IdentifierPacketRegisterEvent.registermethod which accepts PacketTypeIdentifier, <register object>order in the register methods in accordance to register methods already using Identifiers.It might be worth considering removing the String id register methods completely from stuff like entities and block entities
The funciton of the packet type registering tested using a an added test mod packet, everything else is pretty much helper methods
