OpenConceptLab/ocl_issues#2485 | Copy project#13
Open
snyaggarwal wants to merge 1 commit intomainfrom
Open
Conversation
2 tasks
paynejd
reviewed
Apr 24, 2026
Member
paynejd
left a comment
paynejd
left a comment
There was a problem hiding this comment.
Two blockers below (UX inconsistency, broken indentation) plus a label rename:
Rename "Copy" → "Create similar". "Copy" implies a full duplicate. "Create similar" describes the actual behavior (config-only seed). Apply to:
- Button text + tooltip in
Controls.jsxandMapProjects.jsx - i18n keys:
map_project.copy_project→map_project.create_similar(en/es/zh); dropcommon.copy - URL param:
?copyFrom=→?templateFrom=(cheap to change now, expensive once URLs are bookmarked)
|
|
||
| const onCopyClick = event => { | ||
| event.preventDefault() | ||
| event.stopPropagation() |
Member
There was a problem hiding this comment.
Should open in the same tab to match the listing-page button.
Suggested change
| event.stopPropagation() | |
| history.push(`/map-projects/new?copyFrom=${encodeURIComponent(project.url)}`) |
Comment on lines
+158
to
168
| <Button size='small' color='primary' variant='contained' sx={{textTransform: 'none', margin: '0 4px'}} href={`#${project.url}`}> | ||
| {t('common.open')} | ||
| </Button> | ||
| <Button size='small' color='error' variant='text' sx={{marginLeft: '8px', textTransform: 'none'}} onClick={() => setDeleteProject(project)}> | ||
| <Tooltip title={t('map_project.copy_project')}> | ||
| <Button size='small' variant='contained' color='secondary' sx={{margin: '0 4px', textTransform: 'none'}} onClick={event => onCopyClick(event, project)}> | ||
| {t('common.copy')} | ||
| </Button> | ||
| </Tooltip> | ||
| <Button size='small' color='error' variant='text' sx={{margin: '0 4px', textTransform: 'none'}} onClick={() => setDeleteProject(project)}> | ||
| {t('common.delete')} | ||
| </Button> |
Member
There was a problem hiding this comment.
Fix indentation inconsistency.
Suggested change
| <Button size='small' color='primary' variant='contained' sx={{textTransform: 'none', margin: '0 4px'}} href={`#${project.url}`}> | |
| {t('common.open')} | |
| </Button> | |
| <Button size='small' color='error' variant='text' sx={{marginLeft: '8px', textTransform: 'none'}} onClick={() => setDeleteProject(project)}> | |
| <Tooltip title={t('map_project.copy_project')}> | |
| <Button size='small' variant='contained' color='secondary' sx={{margin: '0 4px', textTransform: 'none'}} onClick={event => onCopyClick(event, project)}> | |
| {t('common.copy')} | |
| </Button> | |
| </Tooltip> | |
| <Button size='small' color='error' variant='text' sx={{margin: '0 4px', textTransform: 'none'}} onClick={() => setDeleteProject(project)}> | |
| {t('common.delete')} | |
| </Button> | |
| <Button size='small' color='primary' variant='contained' sx={{margin: '0 4px', textTransform: 'none'}} href={`#${project.url}`}> | |
| {t('common.open')} | |
| </Button> | |
| <Tooltip title={t('map_project.copy_project')}> | |
| <Button size='small' variant='contained' color='secondary' sx={{margin: '0 4px', textTransform: 'none'}} onClick={event => onCopyClick(event, project)}> | |
| {t('common.copy')} | |
| </Button> | |
| </Tooltip> | |
| <Button size='small' color='error' variant='text' sx={{margin: '0 4px', textTransform: 'none'}} onClick={() => setDeleteProject(project)}> | |
| {t('common.delete')} | |
| </Button> |
| } | ||
| if(copyFromProjectURL) { | ||
| copyFromProject() | ||
| } |
Member
There was a problem hiding this comment.
copyFromProjectURL is read inside this effect but missing from deps. If mount-only is intentional, add // eslint-disable-next-line react-hooks/exhaustive-deps with a one-line reason.
| } | ||
|
|
||
| const fetchAndSetProject = () => { | ||
| setLoadingProject(true) |
Member
There was a problem hiding this comment.
Prefill name with "Copy of {original name}" so users don't land on a blank field. Requires adding name to the /configurations/ API response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Ref OpenConceptLab/ocl_issues#2485