feat: Adds pipe friction method selection#75
Merged
dietmarw merged 5 commits intoOpenSimHub:masterfrom Feb 10, 2026
Merged
Conversation
Adds functionality to specify pipe friction using different methods: pipe roughness, Moody friction factor, or Manning coefficient. This enhancement simplifies friction specification and offers flexibility for various application scenarios.
dietmarw-se
added a commit
to dietmarw/OpenHPL
that referenced
this pull request
Feb 18, 2026
* Splits the Turbine into a BaseValve and Turbine model Fixes OpenSimHub#75 At the same time a simple valve component is introduced which is based on the `BaseValve` model just like the turbine model is now also based on this. An example model was also added. * Simplify the example parameters. * Rename the examples to reflect the turbine usage Since we now have a `SimpleValve` model a it seems better to emphasise when a turbine is part of the example. * Syntax clean up. * Refactor: Generalize BaseValve interface and parameter descriptions * Feat: Introduce mass flow rate for compressibility calculation * Chore: Remove redundant 'visible' annotation from Valve icon --------- Co-authored-by: Dietmar Winkler <dietmar.winkler@skagerakenergi.no>
dietmarw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to specify pipe friction using different methods:
pipe roughness, Moody friction factor, or Manning coefficient.
This enhancement simplifies friction specification and offers flexibility
for various application scenarios.