Skip to content

ci: add markdownlint#30

Open
rwaffen wants to merge 4 commits intoOpenVoxProject:masterfrom
rwaffen:markdownlint
Open

ci: add markdownlint#30
rwaffen wants to merge 4 commits intoOpenVoxProject:masterfrom
rwaffen:markdownlint

Conversation

@rwaffen
Copy link
Copy Markdown
Member

@rwaffen rwaffen commented Feb 11, 2026

No description provided.

@rwaffen rwaffen requested a review from jay7x February 11, 2026 10:34
@jay7x
Copy link
Copy Markdown
Contributor

jay7x commented Feb 11, 2026

TY! I'll adjust it and merge after rubocop PR!

@jay7x
Copy link
Copy Markdown
Contributor

jay7x commented Feb 12, 2026

This works fine, but now I think we may want to use Ruby-based markdown linter instead:

Will compare both and see..

@tuxmea
Copy link
Copy Markdown
Contributor

tuxmea commented Apr 21, 2026

@jay7x Any news regarding your tests with ruby based markdownlint?

@jay7x
Copy link
Copy Markdown
Contributor

jay7x commented Apr 21, 2026

Forgot about this tbh.. will try to have a look tonight

@jay7x
Copy link
Copy Markdown
Contributor

jay7x commented Apr 21, 2026

Well.. I spent some time on this. Below are quick results.

➜  openvox-docs git:(master) ✗ grep -c 'MD[0-9]*' mdl.output          
88107
➜  openvox-docs git:(master) ✗ grep -c 'MD[0-9]*' markdownlint-cli2.output 
88419
➜  openvox-docs git:(master) ✗ tail -n1 mdl.output 
9.65s user 0.60s system 99% cpu 10.258 total
➜  openvox-docs git:(master) ✗ tail -n1 markdownlint-cli2.output 
11.23s user 0.76s system 132% cpu 9.022 total

NOTES:

  • mdl.output is Ruby-based linter output (time bundle exec mdl **/*.md **/*.markdown > mdl.output 2>&1)
  • markdownlint-cli2.output is Node-based markdownlint-cli2 output (time npx markdownlint-cli2 **/*.md **/*.markdown > markdownlint-cli2.output 2>&1)
  • Both outputs were edited to remove non-rule output
  • Run was made on a non-clean repo, so there is a mix of old and new repos actually.. I don't think that really matters in this case though.

@jay7x
Copy link
Copy Markdown
Contributor

jay7x commented Apr 21, 2026

Speed-wise I'd say they are quite similar.

Strong sides of linters:

  • markdownlint-cli2 has slightly more rules (looking at the output).
  • mdl is Ruby-based, so we can bake it into our future SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants