Skip to content

Watcher's eye trade search#7169

Closed
bornaivankovic wants to merge 7 commits intoPathOfBuildingCommunity:devfrom
bornaivankovic:dev
Closed

Watcher's eye trade search#7169
bornaivankovic wants to merge 7 commits intoPathOfBuildingCommunity:devfrom
bornaivankovic:dev

Conversation

@bornaivankovic
Copy link
Copy Markdown
Contributor

@bornaivankovic bornaivankovic commented Dec 25, 2023

Description of the problem being solved:

Simplify process of finding potential Watcher's eyes for your build.

After screenshot:

image
image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Dec 26, 2023
@LocalIdentity
Copy link
Copy Markdown
Contributor

Had a test of this PR and it worked as expected but there were some potential issues I ran into

  • If you already have a Watcher's Eye in your build and you generate weights on a socket that does not currently contain the active Watchers Eye, it will not remove the original Watcher's Eye from the build before generating new weights and will also not generate a minimum weight value. People will probs make this mistake and have no idea that the weights are wrong
  • With the Watcher's Eye search being hidden behind the jewel options I believe many people will not realise that it exists. I think it would be better to have it located below the Megalomaniac search in the main UI

We have a PoB dev Discord server that allows much easier communication, send me a friend request or message (LocalIdentity) and I'll send you an invite to the server

	- move find button to separate slot instead of using exisitng jewel sockets
	- use exisitng Watcher's Eye slot(if available) for usage in weight calculations with test item
	- added option to include rest of applicable mods from Watcher's Eye mod pool that have weight 0 in final query
@bornaivankovic bornaivankovic marked this pull request as draft January 30, 2024 20:12
@jokeaa
Copy link
Copy Markdown

jokeaa commented Dec 3, 2025

Has this feature been updated to the main version yet? I think i really need this feature,please!

@bornaivankovic
Copy link
Copy Markdown
Contributor Author

Honestly I forgot about this PR as I'm not an active pob dev and I kind of burned out on poe. I'm assuming it would require more work after rebasing to latest upstream version due to new features implemented in pob in last couple of years since I last worked on this feature. I might pick it up during upcoming winter break, but no promise.

@jokeaa
Copy link
Copy Markdown

jokeaa commented Dec 4, 2025

That's okay.I`m not pushing any thing here. I just think this PR is a great addition to POB's functionality. Of course, when it comes to equipment weighting, many unique items would require similar adjustments, but that also involves a lot of work. I would be very grateful if you could spend your precious time completing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants