Skip to content

Fix issue with converted damage showing no poison stacks #8991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 4 commits into from
Apr 16, 2026
+4 −1
Merged

Fix issue with converted damage showing no poison stacks #8991

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2982a01
Update CalcOffence.lua
wh98yap-hub Sep 25, 2025
1e761bf
Merge branch 'dev' into poison
Apr 16, 2026
275d89c
Revert to dev
Apr 16, 2026
c8b96f3
Fix
Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4418,7 +4418,10 @@ function calcs.offence(env, actor, activeSkill)
durationMod = m_max(durationMod, 0)
globalOutput.PoisonDuration = durationBase * durationMod / rateMod * debuffDurationMult
-- The chance any given hit applies poison
local poisonChance = output.PoisonChanceOnHit / 100 * (1 - output.CritChance / 100) + output.PoisonChanceOnCrit / 100 * output.CritChance / 100
local chaosPoisonChance = (output.ChaosHitAverage or 0) > 0 and output.ChaosPoisonChance or 0
local poisonChanceOnHit = m_min(100, output.PoisonChanceOnHit + chaosPoisonChance)
local poisonChanceOnCrit = m_min(100, output.PoisonChanceOnCrit + chaosPoisonChance)
local poisonChance = poisonChanceOnHit / 100 * (1 - output.CritChance / 100) + poisonChanceOnCrit / 100 * output.CritChance / 100

-- Handling of "inflict x additional poisons"
local additionalPoisonStacks = 1
Expand Down
Loading