Fix Poisonous Concoction Added Damage from Disabled Life Flasks#9339
Merged
LocalIdentity merged 5 commits intoPathOfBuildingCommunity:devfrom Apr 16, 2026
Merged
Conversation
LocalIdentity
approved these changes
Nov 23, 2025
LocalIdentity
requested changes
Nov 23, 2025
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
If you have multiple disabled life flasks it should choose the highest one instead of being random. It needs the logic to only override the multiplier if it's greater than a different flask
Peechey
added
bug: calculation
Handle it all in the ordered slot loop so it doesn't need to be called on again
LocalIdentity
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7584
Description of the problem being solved:
If your life flask is in a disabled slot, like Flask 5 while using a Micro-Distillery Belt, the lifeRecoveryTotal was not being set for the added damage calc for PConc. This PR will set that multiplier as we are disabling the flask slot. Accounts for multiple disabled life flasks.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: