Skip to content

Fix for Chieftain resist nodes applying effects twice due to Foulborn Choir of the Storm#9643

Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
EminGul:fix-valako-double-apply
Apr 17, 2026
Merged

Fix for Chieftain resist nodes applying effects twice due to Foulborn Choir of the Storm#9643
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
EminGul:fix-valako-double-apply

Conversation

@EminGul
Copy link
Copy Markdown
Contributor

@EminGul EminGul commented Mar 15, 2026

Fixes #9481 .

Description of the problem being solved:

Foulborn Choir of the Storm's increased mana by overcapped lightning resist mod causes resistance conversion mods, such as Taslio, Cleansing Water, to apply twice in calculations.

This is due to how Foulborn Choir of the Storm is handled in the calculations. Since it calls the resistance, mana and reservation calculations again, it adds resistance conversion mods twice as well.

Fix just adds a flag so resistance conversion mods aren't processed twice on accident.

Steps taken to verify a working solution:

  • Check resists are accurate: ~25,000 fire resistance with ~12,500 lightning and cold resistance
  • Check Max res granted by Valako, Storm's Embrace is not double applying to cold/lightning resist
  • Check Mana to Energy Shield no longer double applying and matches with user report
  • Check Transfiguration of Mind applies half the increased damage (in config)
  • Check if non-Foulborn Choir builds have resist/max res from Chieftain nodes works properly

Link to a build that showcases this PR:

https://pobb.in/5cSHvaw15MUI (Screenshots based off this PoB)

https://pobb.in/V41O4IvnojAr (extra case, ES aligns with user report but I'm uncertain mana is accurate as they're saying the in-game UI is bugged. The increased mana aligns with what they're reporting.)

Before screenshot:

fix-tasalio-choir-before

After screenshot:

fix-tasalio-choir-after

EminGul and others added 2 commits March 15, 2026 13:21
Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to use a fake actor and also added a test in case this breaks again in the future

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Apr 17, 2026
@LocalIdentity LocalIdentity merged commit 91aa548 into PathOfBuildingCommunity:dev Apr 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Valako, Storm's Embrace and Tasalio, Cleansing Water Ascendancy nodes applying effects twice

2 participants