Skip to content

trader tool: fix different searches overwriting the last query #9767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Apr 16, 2026
+5 −3
Merged

trader tool: fix different searches overwriting the last query #9767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Classes/TradeQuery.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ local TradeQueryClass = newClass("TradeQuery", function(self, itemsTab)
self.allLeagues = {}
-- realm id-text table to pair realm name with API parameter
self.realmIds = {}
-- last query for each row
self.lastQueries = {}

self.tradeQueryRequests = new("TradeQueryRequests")
main.onFrameFuncs["TradeQueryRequests"] = function()
Expand Down Expand Up @@ -960,7 +962,7 @@ function TradeQueryClass:PriceItemRowDisplay(row_idx, top_pane_alignment_ref, ro
return
end
context.controls["priceButton"..context.row_idx].label = "Searching..."
self.lastQuery = query
self.lastQueries[row_idx] = query
self.tradeQueryRequests:SearchWithQueryWeightAdjusted(self.pbRealm, self.pbLeague, query,
function(items, errMsg)
if errMsg then
Expand Down Expand Up @@ -1041,7 +1043,7 @@ function TradeQueryClass:PriceItemRowDisplay(row_idx, top_pane_alignment_ref, ro
self:SetNotice(controls.pbNotice, "Error: " .. errMsg)
else
self:SetNotice(controls.pbNotice, "")
self.lastQuery = query
self.lastQueries[row_idx] = query
self.resultTbl[row_idx] = items
self:UpdateControlsWithItems(row_idx)
end
Expand Down Expand Up @@ -1180,7 +1182,7 @@ function TradeQueryClass:PriceItemRowDisplay(row_idx, top_pane_alignment_ref, ro
if itemResult.whisper then
Copy(itemResult.whisper)
else
local exactQuery = dkjson.decode(self.lastQuery)
local exactQuery = dkjson.decode(self.lastQueries[row_idx])
-- use trade sum to get the specific item. both min and max
-- weight on site uses floats but only shows integer in the api
-- e.g. weight of 172.3 shows up as 172 in the api
Expand Down
Loading