Fix negative eHP and NaN Max hit values for some builds#9772
Merged
LocalIdentity merged 1 commit intodevfrom Apr 17, 2026
Merged
Fix negative eHP and NaN Max hit values for some builds#9772LocalIdentity merged 1 commit intodevfrom
LocalIdentity merged 1 commit intodevfrom
Conversation
Some builds could show up having negative eHP values or nan max hit when they have single digit life values numHits could become negative which would make eHP show up as negative too Enemy damage conversion could also result in max hit becoming 0 in one part of the code and that would then display as NaN after it tries to divide by 0
LocalIdentity
added
bug: calculation
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Some builds could show up having negative eHP values or nan max hit when they have single digit life values
numHits could become negative which would make eHP show up as negative too
Enemy damage conversion could also result in max hit becoming 0 in one part of the code and that would then display as NaN after it tries to divide by 0
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/qvznz0rl
Before screenshot:
After screenshot: