Fix functions that return structs to return structs, not pointers#39
Draft
ZivDero wants to merge 1 commit intoPhobos-developers:phobos-devfrom
Draft
Fix functions that return structs to return structs, not pointers#39ZivDero wants to merge 1 commit intoPhobos-developers:phobos-devfrom
ZivDero wants to merge 1 commit intoPhobos-developers:phobos-devfrom
Conversation
ZivDero
force-pushed
the
fix-struct-return-functions
branch
from
0ea46af to
9946953
Compare
Member
|
LGTM, but Phobos needs to sync with this change I guess, maybe someone will do it later |
Member
sync how? this should be a drop-in change, assuming no one used the "raw" representation |
Author
Nono, this is definitely not "LGTM". Otherwise, it's not drop-in so long that any of the changed functions that don't have wrappers are used (since the signature changed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.