Exclude dependency from RequiredModules when listed under ExternalModuleDependencies#1973
Open
Exclude dependency from RequiredModules when listed under ExternalModuleDependencies#1973
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSResourceGet currently requires all modules to be found/installed if present under
RequiredModules, even if additionally present underExternalModuleDependencies.RequiredModulesis referred to for the following operations:Install-PSResource,Publish-PSResourceandImport-Module.Previously, PSResourceGet expected the user to not list an external dependency under
RequiredModulesbut this breaksImport-Module. This PR addresses a fix forInstall-PSResource. If the module is listed under ExternalModuleDependencies, it is skipped during installation and a verbose message is written. As theExternalModuleDependenciesmetadata is not returned by the PSGallery server during Find call, it must be retrieved from the.psd1or.ps1metadata file for a PSResource.#1809 also discusses checking the PSModulePath for an ExternalModule dependency and warning the user accordingly, but this PR does not address this yet.
PR Summary
PR Context
Resolves #1809
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.